fix de-escaping too much in query parser #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
reviewed
Jun 10, 2024
query-grammar/src/query_grammar.rs
Outdated
| let require_escape = |c: char| { | ||
| c.is_whitespace() | ||
| || [ | ||
| '-', '^', '`', ':', '{', '}', '"', '\'', '[', ']', '(', ')', '\\', |
There was a problem hiding this comment.
would probably make sense to move this to a const variable and give it a name
philippemnoel
pushed a commit
to paradedb/tantivy
that referenced
this pull request
Aug 31, 2024
* fix de-escaping too much in query parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix broken test in quickwit-oss/quickwit#5093