Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate send blocking in data_moved events #444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Indicate send blocking in data_moved events #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions draft-ietf-quic-qlog-quic-events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,6 +1200,12 @@ processed first and afterwards the application layer reads from the streams with
newly available data). This can help identify bottlenecks, flow control issues,
or scheduling problems.

The `blocked_reason` field supports optional logging of information related to
stream writes getting blocked, either in full or in part. For example, if an
application intended to write data to a stream but was blocked from sending
anything due to congestion control, it can log the `congestion_control` reason
and omit the length field.

The `additional_info` field supports optional logging of information
related to the stream state. For example, an application layer that moves data
into transport and simultaneously ends the stream, can log `fin_set`. As
Expand All @@ -1222,6 +1228,8 @@ QUICStreamDataMoved = {
? from: $DataLocation
? to: $DataLocation

? blocked_reason: $BlockedReason

? additional_info: $DataMovedAdditionalInfo

? raw: RawInfo
Expand All @@ -1233,6 +1241,15 @@ $DataLocation /= "application" /
"transport" /
"network"

$BlockedReason /= "scheduling" /
"pacing" /
"amplification_protection" /
"congestion_control" /
"connection_flow_control" /
"stream_flow_control" /
"stream_id" /
"application"

$DataMovedAdditionalInfo /= "fin_set" /
"stream_reset"
~~~
Expand All @@ -1259,6 +1276,12 @@ are processed first and afterwards the application layer reads all Datagrams at
once). This can help identify bottlenecks, flow control issues, or scheduling
problems.

The `blocked_reason` field supports optional logging of information related to
stream writes getting blocked, either in full or in part. For example, if an
application intended to write data to a stream but was blocked from sending
anything due to congestion control, it can log the `congestion_control` reason
and omit the length field.

This event is only for data in QUIC Datagram Frames. For data in QUIC streams,
see the `stream_data_moved` event defined in {{quic-streamdatamoved}}.

Expand All @@ -1270,6 +1293,8 @@ QUICDatagramDataMoved = {
? to: $DataLocation
? raw: RawInfo

? blocked_reason: $BlockedReason

* $$quic-datagramdatamoved-extension
}
~~~
Expand Down
Loading