Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Add support for custom fonts #430

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[feat]: Add support for custom fonts #430

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
85aa002
Add support for custom fonts
shraddha-kesari May 15, 2023
b55dacd
chore(release): 2.11.1-custom-fonts.0
shraddha-kesari May 15, 2023
518fd2d
Add support for custom fonts
shraddha-kesari May 15, 2023
81e656e
update tests
shraddha-kesari May 15, 2023
b927a25
chore(release): 2.11.1-custom-fonts.2
shraddha-kesari May 15, 2023
af1049c
Support for 4 custom Fonts and add docs
shraddha-kesari May 16, 2023
fd23205
chore(release): 2.11.1-custom-fonts.3
shraddha-kesari May 16, 2023
f7b28fa
Merge master
shraddha-kesari Jun 30, 2023
86458fd
chore(release): 2.17.2-custom-fonts.0
shraddha-kesari Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@quintype/amp",
"version": "2.11.0",
"version": "2.11.1-custom-fonts.3",
"description": "Quintype's AMP component library for publisher apps to create amp layouts",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down
3 changes: 2 additions & 1 deletion src/__fixtures__/config.fixture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,8 @@ export const ampConfig: AMPConfig = {
secondary: {
url: "PT+Serif:400,400italic,700,700italic",
family: "'PT Serif', sans-serif"
}
},
custom: "https://fonts.googleapis.com/css?family=Tangerine"
},
colors: {
primary: "#294f32",
Expand Down
24 changes: 24 additions & 0 deletions src/atoms/fonts/__snapshots__/fonts.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,29 @@ exports[`Fonts component Should match snapshot 1`] = `
href="https://fonts.googleapis.com/css?family=Mukta+Malar:400,400italic,700,700italic&display=swap"
rel="preload"
/>
<link
as="style"
crossorigin="anonymous"
href="https://fea.assettype.com/malibu/assets/MalibuHeadlineSemiBold1.woff2"
rel="preload"
/>
<link
as="style"
crossorigin="anonymous"
href="https://fea.assettype.com/malibu/assets/MalibuHeadlineTextRegular1.woff2"
rel="preload"
/>
<link
as="style"
crossorigin="anonymous"
href="https://fea.assettype.com/malibu/assets/MalibuHeadlineSemiBold2.woff2"
rel="preload"
/>
<link
as="style"
crossorigin="anonymous"
href="https://fea.assettype.com/malibu/assets/MalibuHeadlineTextRegular2.woff2"
rel="preload"
/>
</HelmetWrapper>
`;
Loading