fix( infinite-scroll amp): handle errors in infinite-scroll amp api r…

…esponse (#421)
quintype · Apr 18, 2024 · 8c24b9b · 8c24b9b
1 parent 6de24e2
commit 8c24b9b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@quintype/framework",
-  "version": "7.27.1",
+  "version": "7.27.2-amp-infinite-scroll-errors.0",
   "description": "Libraries to help build Quintype Node.js apps",
   "main": "index.js",
   "engines": {

diff --git a/server/amp/handlers/infinite-scroll.js b/server/amp/handlers/infinite-scroll.js
@@ -6,6 +6,8 @@ const cloneDeep = require("lodash/cloneDeep");
 
 // eslint-disable-next-line consistent-return
 async function storyPageInfiniteScrollHandler(req, res, next, { client, config, ...rest }) {
+  if (!req.query["story-id"]) return res.status(400).send(`Query param "story-id" missing`);
+
   const ampConfig = await config.memoizeAsync("amp-config", async () => await AmpConfig.getAmpConfig(client));
   const opts = cloneDeep(rest);
   const infiniteScrollSource = get(opts, ["featureConfig", "infiniteScroll", "source"], "collection");