Amp text overlap issue #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
October 4, 2023 12:56
VeenaYemmiganur
force-pushed
the
amp-text-overlap-issue
branch
from
ba52e84 to
f0981f4
Compare
added 7 commits
November 7, 2023 11:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
includes the changes for Text overlapping issue in visual stories -
line height rule from 1 to "normal" ,
overlay background
font color
in amp library for Visual Stories .
Fixes # (issue-reference)
https://github.com/quintype/ace-planning/issues/932
Dependencies # (dependency-issue-reference)
quintype/quintype-amp#458
Documentation # (link to the corresponding documentation changes)
Type of change
Please delete options that are not relevant.