Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor entire API to use promises and add missing endpoints #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jesseditson
Copy link
Contributor

@plinehan and/or @mihaip: I do not expect this to land in it's current state, but since I did a bunch of refactoring to use this with my Quiprupt project I figured I'd get this diff up.

  • add blob from URL/Path method
  • move to request lib so we can handle blob form data
  • add connectWebsocket function for using websockets (and ws dependency)
  • make entire API promise based so it can be used with async/await

Also we should probably publish an official lib to npm at some point. Happy to own that project if it's needed, I've done lots of similar stuff in the past.

Jesse Ditson added 2 commits March 16, 2018 17:30
… so we can handle blob form data, add connectWebsocket function for using websockets (and ws dependency), make entire API promise based so it can be used with async/await
@plinehan
Copy link
Contributor

I'm out of my element here but generally this is awesome! Thanks! Publishing to NPM would also be great, thanks for taking the lead.

@mihaip should be the final say.

@mihaip
Copy link
Contributor

mihaip commented Mar 19, 2018

@yangsu is a much better reviewer for this

@jesseditson
Copy link
Contributor Author

Note that if we do want to land this, we'll need to:

  • get a process set up for publishing to npm
  • update the documentation for our automation API
  • conversation about versioning?
  • invest an afternoon to get some tests written for this (I guess this is optional)

@yangsu
Copy link
Contributor

yangsu commented Mar 20, 2018

Exciting! let's schedule a meeting scheduled in person to chat about this!

@yangsu
Copy link
Contributor

yangsu commented Mar 21, 2018

Spoke with @jesseditson in person. here's the gist:

  • talk to @elsigh about licensing and generally about our process for open source
  • setup an entity on npm and publish all of our packages under it
  • split this repo into node and python
  • follow semver for versioning
  • Promises ftw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants