Update quip-apps-webpack-config dependency to match the latest version. #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvnlam
force-pushed
the
kvnlam_dreamy-heisenberg
branch
from
d1e1d0f to
01293f7
Compare
- Remove `prebuild` step since it's causing a lot of typing errors
- Change test workflow to use Node 20 - Change test workflow to run `npm ci` instead of `npm install` - Update Typescript and add React dependencies to ensure compatibility
- Upgrade dependencies as required - Update GitHub test workflows to use Node 20
- This package is also references an outdated version of `quip-apps-webpack-config`
kvnlam
commented
May 2, 2024
| "tape": "^4.11.0", | ||
| "typescript": "^3.6.3" | ||
| "typescript": "^5.4.5" | ||
| }, | ||
| "gitHead": "1633a60816f6da91d4b022751e9f3bfd45ae18c1" |
There was a problem hiding this comment.
i had to update these dependencies to prevent the build from failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background / Why?
We have packages that have been using a really old version of
quip-apps-webpack-config. The current version contains several security vulnerabilities so updating to the latest version should resolve things.This is part of an ongoing effort to tackle our outstanding Snyk tickets: https://jira.tinyspeck.com/browse/QUIPCORE-1540
Summary
Update
quip-apps-webpack-configdependency to match the latest version.Quip Pull Requests & flow | Quip Emergency PR Approval Docs