Test DISCOVERY-437 (bonus: smoke test viewScanList!)

babel.config.js

@@ -1 +1,11 @@
-module.exports = {};
+
+module.exports = (api) => {
+    api.cache(true)
+    const presets = ["@babel/preset-react", "@babel/preset-env"];
+    const plugins = ["@babel/plugin-transform-modules-commonjs"];
+
+    return {
+        presets,
+        plugins
+    };
+}

config/cspell.config.json

@@ -15,6 +15,7 @@
     "elit",
     "fadein",
     "generatedid",
+    "haspopup",
     "labelledby",
     "mturley",
     "nocolor",
@@ -30,6 +31,7 @@
     "rescan",
     "rhacs",
     "rowgroup",
+    "rowindex",
     "runas",
     "scanjob",
     "srcset",

jest.config.js

@@ -30,13 +30,16 @@ module.exports = {
   testMatch: ['<rootDir>/**/__tests__/**/*.{ts,tsx}', '<rootDir>/**/*.{spec,test}.{ts,tsx}'],
   testEnvironment: 'jsdom',
   transform: {
-    '^.+\\.(js|jsx|ts|tsx)$': '<rootDir>/node_modules/ts-jest',
+    '^.+\\.(jsx|ts|tsx)$': '<rootDir>/node_modules/ts-jest',
+    // @mturley-latest/react-table-batteries lib proved to be challenging to properly transform 
+    // using ts-jest; for this reason, js files are transformed with babel for now;
+    '^.+\\.js$': '<rootDir>/node_modules/babel-jest',
     '^.+\\.css$': '<rootDir>/config/jest.transform.style.js',
     '^(?!.*\\.(js|jsx|ts|tsx|css|json)$)': '<rootDir>/config/jest.transform.file.js'
   },
   transformIgnorePatterns: [
-    '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs|cjs|ts|tsx)$',
+    '[/\\\\]node_modules[/\\\\][/\\.+\\\\]*.+\\.(jsx|mjs|cjs|ts|tsx)$',
     '^.+\\.module\\.(css|sass|scss)$'
   ],
-  watchPlugins: ['jest-watch-typeahead/filename', 'jest-watch-typeahead/testname']
+  watchPlugins: ['jest-watch-typeahead/filename', 'jest-watch-typeahead/testname'],
 };

public/locales/en.json

@@ -173,6 +173,7 @@
     "label_satellite": "Satellite",
     "label_rhacs": "RHACS",
     "label_rescan": "Rescan",
+    "label_download": "Download",
     "label_scan": "Scan",
     "label_source": "Source",
     "label_source_other": "Sources",

src/components/actionMenu/actionMenu.tsx

@@ -11,7 +11,7 @@ import { EllipsisVIcon } from '@patternfly/react-icons';
 
 interface ActionMenuProps<T = unknown> {
   item: T;
-  actions: { label: string; onClick: (item: T) => void }[];
+  actions: { label: string; onClick: (item: T) => void; disabled?: boolean }[];
 }
 
 const ActionMenu = <T,>({ item, actions }: ActionMenuProps<T>) => {
@@ -43,6 +43,7 @@ const ActionMenu = <T,>({ item, actions }: ActionMenuProps<T>) => {
             onClick={() => {
               a.onClick(item);
             }}
+            isDisabled={a.disabled}
           >
             {a.label}
           </DropdownItem>

src/helpers/helpers.ts

@@ -9,7 +9,7 @@ import React from 'react';
 import moment, { type MomentInput } from 'moment';
 import titleImg from '../images/title.svg';
 import titleImgBrand from '../images/titleBrand.svg';
-import { type CredentialType } from '../types/types';
+import { type CredentialType, type MostRecentScan, type scanJob } from '../types/types';
 
 /**
  * Is dev mode active.
@@ -226,8 +226,19 @@ const getCurrentDate = () => (TEST_MODE && moment.utc('20241001').toDate()) || m
  */
 const getTitleImg = (isBrand = UI_BRAND) => ((isBrand && titleImgBrand) || titleImg) as string;
 
+/**
+ * Return if a report associated with given ScanJob can be downloaded
+ *
+ * @param {scanJob | MostRecentScan} job
+ * @returns {boolean}
+ */
+const canDownloadReport = (job?: scanJob | MostRecentScan) => {
+  return job?.status === 'completed' && job?.report_id !== undefined;
+};
+
 const helpers = {
   authType,
+  canDownloadReport,
   downloadData,
   noopTranslate,
   generateId,

src/types/types.ts

@@ -174,12 +174,16 @@ export type ScanOptions = {
 export type scanJob = {
   id: number;
   report_id: number;
+  status: string;
 };
 
 export type StatusDetails = {
   job_status_message: string;
 };
 
+// TODO: Considerations for a future refactor: merge and/or rename scanJob and MostRecentScan.
+// Reason: the object returned from the api representing scanJob and MostRecentScan are the same;
+// also, in quipucords jargon, MostRecentScan is a ScanJob, not a Scan.
 export type MostRecentScan = {
   id: number;
   report_id: number;