Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking of using this dependency for a project but saw that it was pretty out of date so I spent a little bit of time cleaning it up.
Changes
lazy_static
because it is no longer needed with new versions ofbase64
Testing
All the units tests except the ones related to
diesel
pass. I'm getting a link error when I enable thediesel
feature flag but I assume that they still pass if you compile the binary in the right environment.Improved Codegen
I took a look at the asm generated for this snippet on both the current version (
master
) and after these changes to see the difference in codegen:On
master
there are lots of branch and allocation calls; meanwhile after updatingbase64
the above function now only contains the following instructions on x86:add, lea, mov, movabs, movups, movzx, or, ret, shr, sub
I haven't measured the performance difference with a benchmark but presumably this new version will be much faster.