Merge pull request #616 from quoid/issue/614

fix: make the `Open Extension Page` button work stably
quoid · Jan 31, 2024 · c51a6cb · c51a6cb
2 parents fc99e1e + 4691267
commit c51a6cb
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/src/ext/action-popup/App.svelte b/src/ext/action-popup/App.svelte
@@ -484,6 +484,11 @@
 		}
 	});
 
+	async function gotoExtensionPage() {
+		await openExtensionPage();
+		window.close();
+	}
+
 	/**
 	 * Temporary settings page entrance for beta test (iOS)
 	 * @todo new permanent button will be added via popup refactoring
@@ -524,7 +529,7 @@
 {/if}
 {#if showBetaNews && platform !== "macos"}
 	<div class="warn">
-		NEW: <button on:click={openExtensionPage}><b>Settings page</b></button> is
+		NEW: <button on:click={gotoExtensionPage}><b>Settings page</b></button> is
 		now available on iOS!
 		<IconButton
 			icon={iconClear}
@@ -594,13 +599,7 @@
 </div>
 {#if !inactive && platform === "macos"}
 	<div class="footer">
-		<button
-			class="link"
-			on:click={() => {
-				openExtensionPage();
-				window.close();
-			}}
-		>
+		<button class="link" on:click={gotoExtensionPage}>
 			Open Extension Page
 		</button>
 	</div>

diff --git a/src/ext/background/main.js b/src/ext/background/main.js
@@ -496,10 +496,10 @@ browser.webNavigation.onCompleted.addListener(setBadgeCount);
 
 // handle native app messages
 const port = connectNative();
-port.onMessage.addListener((message) => {
+port.onMessage.addListener(async (message) => {
 	// console.info(message); // DEBUG
 	if (message.name === "SAVE_LOCATION_CHANGED") {
-		openExtensionPage();
+		await openExtensionPage();
 		if (message?.userInfo?.returnApp === true) {
 			sendNativeMessage({ name: "OPEN_APP" });
 		}

diff --git a/src/ext/shared/utils.js b/src/ext/shared/utils.js
@@ -373,8 +373,8 @@ export async function openExtensionPage() {
 	const tabs = await browser.tabs.query({ url });
 	const tab = tabs.find((e) => e.url.startsWith(url));
 	if (!tab) return browser.tabs.create({ url });
-	browser.tabs.update(tab.id, { active: true });
-	browser.windows.update(tab.windowId, { focused: true });
+	await browser.tabs.update(tab.id, { active: true });
+	await browser.windows.update(tab.windowId, { focused: true });
 }
 
 /**