iterator is too much

quora · Jul 22, 2024 · 2c46f4e · 2c46f4e
1 parent 49b41bb
commit 2c46f4e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -2,7 +2,7 @@
 
 ## Unreleased
 
-- Flag use of iterators that are immediately discarded (#800)
+- Flag use of generators that are immediately discarded (#800)
 - Fix crash on some occurrences of `ParamSpec` in stub files (#797)
 - Fix crash when Pydantic 1 is installed (#793)
 - Fix error on use of TypeVar defaults in stubs (PEP 696). The

diff --git a/pyanalyze/name_check_visitor.py b/pyanalyze/name_check_visitor.py
@@ -4658,8 +4658,8 @@ def visit_Expr(self, node: ast.Expr) -> Value:
             self._show_error_if_checking(
                 node, error_code=ErrorCode.missing_await, replacement=replacement
             )
-        elif value.is_type(collections.abc.Iterator) or value.is_type(
-            collections.abc.AsyncIterator
+        elif value.is_type(collections.abc.Generator) or value.is_type(
+            collections.abc.AsyncGenerator
         ):
             self._show_error_if_checking(
                 node,

diff --git a/pyanalyze/test_name_check_visitor.py b/pyanalyze/test_name_check_visitor.py
@@ -2272,7 +2272,12 @@ def capybara() -> None:
             gen()  # E: must_use
 
     @assert_passes()
-    def test_iterator(self):
+    def test_async_generator(self):
+        from typing import AsyncGenerator
+
+        async def gen() -> AsyncGenerator[int, None]:
+            yield 1
+            yield 2
+
         def capybara() -> None:
-            iter([])  # E: must_use
-            iter({})  # E: must_use
+            gen()  # E: must_use