Skip to content

Commit

Permalink
Merge pull request #91 from qutech/feature/Device_Object
Browse files Browse the repository at this point in the history
Feature/device object
  • Loading branch information
THuckemann authored Aug 14, 2024
2 parents c16dc87 + 99b6ed2 commit 06ddb32
Show file tree
Hide file tree
Showing 11 changed files with 1,020 additions and 73 deletions.
2 changes: 2 additions & 0 deletions src/qumada/instrument/buffers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
Buffer,
BufferException,
is_bufferable,
is_triggerable,
map_buffers,
)
from qumada.instrument.buffers.dummy_dmm_buffer import DummyDMMBuffer
Expand All @@ -32,6 +33,7 @@
"BufferException",
"map_buffers",
"is_bufferable",
"is_triggerable",
"MFLIBuffer",
"SR830Buffer",
"DummyDMMBuffer",
Expand Down
3 changes: 2 additions & 1 deletion src/qumada/instrument/buffers/buffer.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ def is_bufferable(object: Instrument | Parameter):
"""Checks if the instrument or parameter is bufferable using the qumada Buffer definition."""
if isinstance(object, Parameter):
object = object.root_instrument
return hasattr(object, "_qumada_buffer") and isinstance(object._qumada_buffer, Buffer)
return hasattr(object, "_qumada_buffer") # and isinstance(object._qumada_buffer, Buffer)
# TODO: check, if parameter can really be buffered
# TODO: For some reason checking the type doesn't work all the time. Check again later.


def is_triggerable(object: Instrument | Parameter):
Expand Down
3 changes: 2 additions & 1 deletion src/qumada/instrument/buffers/dummy_dmm_buffer.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from jsonschema import validate
from qcodes.parameters import Parameter

from qumada.instrument.buffers.buffer import Buffer, BufferException
from qumada.instrument.buffers import Buffer, BufferException
from qumada.instrument.custom_drivers.Dummies.dummy_dmm import DummyDmm


Expand Down Expand Up @@ -117,6 +117,7 @@ def read_raw(self) -> dict:
index = self._device.buffer.subscribed_params.index(parameter)
data[parameter.name] = self._device.buffer.get()[index]
data[parameter.name] = data[parameter.name][self.delay_data_points : self.num_points]
data["timestamps"] = np.linspace(0, self.num_points / self._device.buffer_SR(), self.num_points)
return data

def read(self) -> dict:
Expand Down
5 changes: 5 additions & 0 deletions src/qumada/instrument/custom_drivers/Dummies/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
"""
Created on Fri May 10 16:46:48 2024
@author: Huckemann
"""
2 changes: 1 addition & 1 deletion src/qumada/instrument/custom_drivers/Dummies/dummy_dmm.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def __init__(self, name, trigger_event=threading.Event(), **kwargs):
"buffer_SR",
unit="Sa/s",
set_cmd=None,
vals=vals.Ints(0, 512),
vals=vals.Numbers(0, 512),
)

self.add_parameter(
Expand Down
Loading

0 comments on commit 06ddb32

Please sign in to comment.