Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing priority from dyn params after sorting them to fix compensation #111

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

THuckemann
Copy link
Collaborator

Some small fix to make compensation work for measurements started from the device object.
generate_lists() would add a priority to all dynamic channels, which then failed a dictionary comparison during the part responsible for the compensation. This is fixed by removing the priority again after the channels were sorted accordingly.

Closes #106

@THuckemann THuckemann added the bug Something isn't working label Nov 11, 2024
@THuckemann THuckemann self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 22.33%. Comparing base (c49b60d) to head (7947f33).

Files with missing lines Patch % Lines
src/qumada/measurement/measurement.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   22.35%   22.33%   -0.03%     
==========================================
  Files          38       38              
  Lines        4620     4625       +5     
==========================================
  Hits         1033     1033              
- Misses       3587     3592       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

  4 files  ±0    4 suites  ±0   11s ⏱️ ±0s
 25 tests ±0   25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7947f33. ± Comparison against base commit c49b60d.

@THuckemann THuckemann merged commit 24248f7 into main Nov 11, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compensation does not work for device object based measurements.
1 participant