-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
6 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
ALTER TABLE qwat_od.part | ||
DROP CONSTRAINT part_id_fkey, | ||
ADD CONSTRAINT part_id_fkey FOREIGN KEY (id) REFERENCES qwat_od.network_element (id) MATCH SIMPLE; | ||
|
||
UPDATE qwat_sys.versions SET version = '1.2.5'; |
e2bf037
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sylvainbeo PR was green. Since then @haubourg released an older version (1.2.2) without title. I fixed the title but it's still failing. Do you have an explanation?
e2bf037
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3nids not sure I get the title problem, what is missing exactly?
Like you, I don't get why just pushing a tag now fails the PR.
e2bf037
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not the PR but the test on the last commit in the master branch
e2bf037
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i do. In the verify_upgrade_db.sh i read the latest tag version by doing :
LATEST_TAG=$(git describe)
SHORT_LATEST_TAG=$(echo $LATEST_TAG| cut -c 1)
But i think, it's wrong, i'm on it.
e2bf037
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3nids Mmm in fact, not sure it's the same problem.
e2bf037
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3nids @haubourg The tag number should be 1.2.2 not v1.2.2
e2bf037
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed.