Skip to content

Commit

Permalink
Merge pull request #692 from qwikifiers/changeset-release/main
Browse files Browse the repository at this point in the history
Version Packages
  • Loading branch information
thejackshelton authored Apr 15, 2024
2 parents e9ccb07 + 59279a6 commit 3524202
Show file tree
Hide file tree
Showing 10 changed files with 203 additions and 91 deletions.
60 changes: 0 additions & 60 deletions .changeset/eight-spiders-brake.md

This file was deleted.

7 changes: 0 additions & 7 deletions .changeset/mighty-snails-exist.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/tough-keys-rest.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/warm-pans-drum.md

This file was deleted.

2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"yargs": "17.7.2"
},
"devDependencies": {
"@qwik-ui/styled": "0.0.5"
"@qwik-ui/styled": "0.0.6"
},
"type": "commonjs",
"main": "./src/index.js",
Expand Down
67 changes: 67 additions & 0 deletions packages/kit-headless/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,72 @@
# Changelog

## 0.3.6

### Patch Changes

- 🐞🩹 modal does not close unless the dialog backdrop is clicked (including dangling content) (by [@thejackshelton](https://github.com/thejackshelton) in [#702](https://github.com/qwikifiers/qwik-ui/pull/702))

fix: polyfilled popovers render correctly inside of modals.

fix: nested modals will now close the current modal when the backdrop is clicked.

fix: nested modals will now close the current modal when the escape key is pressed.

fix: select does not execute code until interaction (including core).

tests: larger test suite for modals.

deprecated: `ModalHeader`, `ModalContent`, `ModalFooter` have been deprecated, as they do not pose significant a11y advantages.

feat: Two new Modal component pieces. `ModalTitle` and `ModalDescription`. These help give our modal an accessible name and supporting description (optional).

feat: Modal now uses the following CSS as a default inside of an @layer

```css
@layer qwik-ui {
/* browsers automatically set an interesting max-width and max-height for dialogs
https://twitter.com/t3dotgg/status/1774350919133691936
*/
dialog:modal {
max-width: unset;
max-height: unset;
}
}
```

The default browser styles:

![alt text](image.png)

Make it difficult to style a dialog element full-screen, which has led to some confusion recently both in this repo and across the web. The above change strips the responsible browser styles from the dialog eleemnt (which is used by Qwik UI's modal component).

> For more info, feel free to check out the link in the code snippet above.
> Note: In the future, we intend to use the dot notation for the `Modal` component.
> Note: In the future, we intend to change the modal API to include a trigger. The proposed API is as follows:
### Syntax Proposal

```tsx
<Modal.Root>
<Modal.Trigger>Trigger</Modal.Trigger>
<Modal.Panel>
{/* This is the current <Modal /> */}
<Modal.Title>Edit Profile</Modal.Title>
<Modal.Description>You can update your profile here.</Modal.Description>
</Modal.Panel>
</Modal.Root>
```

Let us know your thoughts on this potential API change in the Qwik UI discord!

- ✨ deprecate `modal-showing` and `modal-closing` classes in favor of `data-open`, `data-closing`, and `data-closed` data attributes. (by [@thejackshelton](https://github.com/thejackshelton) in [#702](https://github.com/qwikifiers/qwik-ui/pull/702))

> These classes will still work at the moment, but will be removed in a near future release.
- refactor: popover listbox class deprecated and set as a default when in floating mode. (by [@thejackshelton](https://github.com/thejackshelton) in [#691](https://github.com/qwikifiers/qwik-ui/pull/691))

## 0.3.5

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/kit-headless/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@qwik-ui/headless",
"version": "0.3.5",
"version": "0.3.6",
"description": "Qwik UI headless components library",
"publishConfig": {
"access": "public"
Expand Down
6 changes: 6 additions & 0 deletions packages/kit-styled/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# @qwik-ui/styled

## 0.0.6

### Patch Changes

- refactor change CardTitle font-weight to medium (by [@maiieul](https://github.com/maiieul) in [#693](https://github.com/qwikifiers/qwik-ui/pull/693))

## 0.0.5

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/kit-styled/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@qwik-ui/styled",
"version": "0.0.5",
"version": "0.0.6",
"description": "Qwik UI components library with styles",
"publishConfig": {
"access": "public"
Expand All @@ -18,7 +18,7 @@
"@builder.io/qwik": "^1.1.0"
},
"devDependencies": {
"@qwik-ui/headless": "0.3.5",
"@qwik-ui/headless": "0.3.6",
"@qwik-ui/utils": "0.2.1"
}
}
Loading

0 comments on commit 3524202

Please sign in to comment.