-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new switch component #960
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a10ddbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
…/qwik-ui into add_component_switch
Hey Jerry! Just went through the implementation. We're getting close! A couple of areas of improvement:
https://kobalte.dev/docs/core/components/switch/ I think this is a good source of inspiration to look at. Along with a set of resources I created here: For example, I think it makes a lot of sense to have a new component tied to a piece of markup for the thumb, rather than having it be on a pseudo element, since that would follow the principles of composability. The idea that pieces of markup and components can blend in with each other in a straightforward way. Atomic Design is a good read if you'd like to look further into it. I think TDD / adding some tests would help a lot to prevent regressions and keep things robust. We need some tests before we can put the switch component in the beta stage. |
Thank you for reviewing, I will fix it soon |
What is it?
Why is it needed?
Checklist:
pnpm change
and documented my changes