Add Context Menu command for Whois #868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The /whois command has the following check: @app_commands.check(is_reader)But since the context menu command is run differently, this doesn't work there The is_reader function should be removed from the app_commands.check and moved into the get_note_command, so it checks equally on both the context menu and slash command calls Additionally, can you add an empty line at the bottom of the .gitignore file? |
dkay0670
force-pushed
the
patch-who
branch
2 times, most recently
from
74c4652 to
8700ae8
Compare
SaintTheAce
approved these changes
Feb 14, 2024
TheKrol
requested changes
Apr 1, 2024
|
I still don't understand why the test is failing
On Friday, July 05, 2024 11:00 PDT, ajax146 ***@***.***> wrote:
@dkay0670 @TheKrol What is the status on this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#868 (comment)", "url": "#868 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]***>
|
|
nvm wrong pr, I just need to fix it, I'll set myself a reminder |
|
You should just ignore the test on the other one, I am reworking all the tests, to make them actually useful. It will fix the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Context Menu command for Whois