Skip to content
This repository has been archived by the owner on Jul 7, 2024. It is now read-only.

Ducks: Added the ducks module #25

Merged
merged 8 commits into from
Nov 7, 2023
Merged

Ducks: Added the ducks module #25

merged 8 commits into from
Nov 7, 2023

Conversation

Cpt-Dingus
Copy link
Collaborator

The contents will probably still be modified, pending review

@Cpt-Dingus
Copy link
Collaborator Author

Cpt-Dingus commented Aug 28, 2023

1) The timeout map needs to be added
2) The collector does not filter the messages to be from said channel

@Cpt-Dingus
Copy link
Collaborator Author

I already see a bunch of issues, I qill be going theough this again tomorrown

@Cpt-Dingus
Copy link
Collaborator Author

.toJSON() is needed

oh it is very much needed

@zleyyij zleyyij self-requested a review September 9, 2023 19:21
Copy link
Collaborator

@zleyyij zleyyij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, review done in discord, not approving because there's still work to do.
Feel free to merge yourself when work finished

Copy link
Collaborator

@zleyyij zleyyij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zleyyij zleyyij merged commit d1151ee into main Nov 7, 2023
1 check passed
@zleyyij zleyyij deleted the ducks_yeah_woo branch November 7, 2023 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants