-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Arrange the DBI::Id()
object in SQL order
#427
Conversation
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a low-risk change to me.
@eauleaf in general it's easier to review PRs if you make the minimum set of changes to the existing package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Per your comments, revised pull request to minimize changes and added another test.
Co-authored-by: Hadley Wickham <[email protected]>
DBI::Id()
object in SQL order
Nice, thanks! |
My package uses
DBI::Id()
to write out SQL viadbQuoteIdentifier()
, but success or failure of the SQL statement depends on the order that users input the Id params. In my package, I overwrote theId()
function to create a similar DBI object, but this issue appears to have been a problem for others as well.Changes correct my issue, which is identical to this closed issue:
r-dbi/odbc#214
Might fix this user's issue:
#426
Closes #383.