Adapt unittest for read_txt_Renishaw() function #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GegznaV
requested changes
Aug 5, 2021
GegznaV
requested changes
Aug 6, 2021
R/read_txt_Renishaw.R
Outdated
| path <- system.file("extdata/fileio/txt.Renishaw", package="hySpc.read.txt") | ||
| paracetamol <- paste0(path, "/paracetamol.txt") | ||
| laser <- paste0(path, "/laser.txt.gz") | ||
| chondro <- paste0(path, "/chondro.txt") |
There was a problem hiding this comment.
Can you, please, not use the names paracetamol, laser, and chondro for file names. Use f_paracetamol, f_laser, and f_chondro instead.
|
I think, for "Adapt unittest for read_txt_Renishaw() function" PR these changes would be OK. But after merging, "Improve unit test for read_txt_Renishaw() function" PR should be created and each imported object should be tested using this template: |
GegznaV
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.