Fix configuration of breaks when using recent scales package. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release of the scales package has added a pair of optional arguments, `d_transform` and `d_inverse`, in the middle of the parameter list for `trans_new` (see r-lib/scales#341). As a consequence, this has shifted the position of the `breaks` parameter from 4th to 6th. Because the `bench_time_trans` and `bench_bytes_trans` functions from this package were passing in the breaks object positionally, this change in the scales package means that the breaks object is now matched with the new `d_transform` formal parameter and it ends up being ignored. This commit changes the arguments to `trans_new` from being positional to being named, which should be more robust to future changes to the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144
Closes #143
The latest release of the scales package has added a pair of optional arguments,
d_transformandd_inverse, in the middle of the parameter list fortrans_new(see r-lib/scales#341). As a consequence, this has shifted the position of thebreaksparameter from 4th to 6th.Because the
bench_time_transandbench_bytes_transfunctions from this package were passing in the breaks object positionally, this change in the scales package means that the breaks object is now matched with the newd_transformformal parameter and it ends up being ignored.This commit changes the arguments to
trans_newfrom being positional to being named, which should be more robust to future changes to the function.