Skip NA test on RISCV64, it is non-portable #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: r-lib#485 Inspired by r-lib#485 (comment)
|
Disclaimer - I've nothing to do with fs development but, FWIW, my comment assumed you were patching downstream in Debian with the understanding that R generally will be a little broken on riscv. I'm not sure skipping the test upstream is the right way to go. Personally I'd want to see that failure (the formatting is broken on riscv and this shows that). If upstream did decide to skip it they will probably want to do it by the testthat skip mechanism so it is atleast flagged in their test suite for future consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #485
Inspired by #485 (comment)