fix: Fix printing of infinite times (#710)

r-lib · Dec 14, 2024 · 951a63e · 951a63e
1 parent 11822e2
commit 951a63e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/R/shaft-.R b/R/shaft-.R
@@ -277,7 +277,7 @@ pillar_shaft.POSIXt <- function(x, ...) {
   date <- format(x, format = "%Y-%m-%d")
   time <- format(x, format = "%H:%M:%OS")
 
-  datetime <- paste0(date, " ", style_subtle(time))
+  datetime <- paste0(date, ifelse(is.finite(x), paste0(" ", style_subtle(time)), ""))
   datetime[is.na(x)] <- NA
 
   new_pillar_shaft_simple(datetime, width = width, align = "left")

diff --git a/tests/testthat/_snaps/shaft-.md b/tests/testthat/_snaps/shaft-.md
@@ -7,3 +7,12 @@
       <SQL>
       x    
 
+# Infinite times (#645)
+
+    Code
+      pillar(.POSIXct(Inf))
+    Output
+      <pillar>
+      <dttm>
+      Inf   
+
diff --git a/tests/testthat/test-shaft-.R b/tests/testthat/test-shaft-.R
@@ -4,3 +4,9 @@ test_that("S4 character class (tidyverse/tibble#1367)", {
     pillar(DBI::SQL("x"))
   })
 })
+
+test_that("Infinite times (#645)", {
+  expect_snapshot({
+    pillar(.POSIXct(Inf))
+  })
+})