feat: Show missing values in red in glimpse()
#662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
Jun 29, 2024
R/glimpse.R
Outdated
| @@ -144,7 +144,10 @@ format_glimpse.default <- function(x, ...) { | |||
| dims_out <- paste0(dims, collapse = " x ") | |||
| paste0("<", class(x)[[1]], "[", dims_out, "]>") | |||
| } else { | |||
| format(x, trim = TRUE, justify = "none") | |||
| out <- format(x, trim = TRUE, justify = "none") | |||
There was a problem hiding this comment.
This looks like an opportunity to remove the negation from the if condition.
R/glimpse.R
Outdated
| } | ||
| out[is.na(x)] <- crayon_red(NA) |
There was a problem hiding this comment.
This looks like a pattern that we use in many places: assign a red NA string to a vector where another vector has NA values.
- Should this be a function?
- Should this be
crayon_red(NA)orcrayon_red(out[is.na(x)])instead?
krlmlr
changed the title
glimpse()
|
I added tests and a |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to make glimpse show NAs in red., as brought up in #658.