feat: New tbl_nrow() to support lazy data frames
#679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
force-pushed
the
f-duckplyr-prep
branch
from
a03ab52 to
839e0e0
Compare
krlmlr
force-pushed
the
f-duckplyr-prep
branch
2 times, most recently
from
9122f66 to
ba184c3
Compare
|
Would you mind pulling the style changes into a separate PR? That would make it easier to see what you're proposing here. |
|
The important commit is the last one, ba184c3 . You could take a look at that, I'll also split this PR. |
hadley
approved these changes
Nov 22, 2024
krlmlr
force-pushed
the
f-duckplyr-prep
branch
from
ba184c3 to
d1b7f30
Compare
krlmlr
force-pushed
the
f-duckplyr-prep
branch
from
d1b7f30 to
038c068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for duckplyr because
dim(x)still dispatches todim.data.frame()for subclasses of"data.frame".Includes other refactorings.