Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --without-sysreqs works #188

Merged
merged 2 commits into from
Sep 24, 2023
Merged

fix: --without-sysreqs works #188

merged 2 commits into from
Sep 24, 2023

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Sep 24, 2023

Fix #184

@eitsupi eitsupi marked this pull request as draft September 24, 2023 13:53
@eitsupi
Copy link
Contributor Author

eitsupi commented Sep 24, 2023

I'm not sure if this solution is correct.
That is, since PKG_SYSREQS="false" is set by Rprofile, the user cannot override this setting and temporarily make PKG_SYSREQS="true" available by setting PKG_SYSREQS in an environment variable or Renviron, right?

@gaborcsardi
Copy link
Member

I think it should only set it if it is not already set:

if (Sys.getenv("PKG_SYSREQS") != "") Sys.setenv(PKG_SYSREQS = "false")

The user or system profile can override it, I think, since it runs after this "internal" profile.

@eitsupi eitsupi marked this pull request as ready for review September 24, 2023 14:06
@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi merged commit 1e33578 into r-lib:main Sep 24, 2023
21 checks passed
@eitsupi eitsupi deleted the sysreqs branch September 24, 2023 19:20
@eitsupi
Copy link
Contributor Author

eitsupi commented Sep 25, 2023

Thanks for merging.
Could you consider patch release?

@gaborcsardi
Copy link
Member

Yes, we'll have one at some point, but a release is quite a lot of work.

If you need a quick workaround for the current release, you can use --without-sysreqs and set up the PKG_SYSREQS env var system wide.

Alternatively, for x86_64 Linux you can download a build from a nightly test artifact, e.g. https://github.com/r-lib/rig/actions/runs/6295783883

@eitsupi
Copy link
Contributor Author

eitsupi commented Sep 25, 2023

I see, thanks for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--without-sysreqs is not working?
2 participants