-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformation suffixes to prefixes (attempt 2) #410
Conversation
Let's rename it all :-) but keep the old around |
Right, but if we call it |
Merge branch 'main' into transform_alias # Conflicts: # NEWS.md # R/scale-continuous.R # man/cscale.Rd # man/pal_shape.Rd
|
Alright, should be OK now |
Thanks! |
It seems like the old were not kept around which causes issues downstream. Could this be remedied? |
Could you be specific about which functions are missing? |
Sorry, should have been more specific! I'm having an issue with backwards compatibility for 'trans' in previously functional scripts |
Do you have a minimal reproducible example of what previously worked fine and is giving issues now? |
I'll get back to you on this. Thanks for the prompt attention! |
This PR aims to fix #390. It supplants #397.
It does the following:
*_trans
suffixed functions totransform_*
prefixed functions. The suffixed versions are kept as an alias."trans"
objects to"transform"
class objects.as.transform()
, previouslyas.trans()
has mechanism to look for the prefixed names first, then tries to find suffixed versions.I was unsure about if
trans_new()
ortrans_range()
should be renamed. As they aren't transformations, I didn't rename them. I'd be happy to rename them if so desired.