breaks_pretty()
will return zero-range limit
#455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #446.
Briefly, it ensures that
breaks_pretty()
with zero-rangex
returns the one limit.In more detail, the precedence of #446 is as follows:
transform_time()$breaks
isbreaks_pretty()
.breaks_pretty()
usespretty()
pretty.Date()
usesgrDevices:::prettyDate()
The only time {scales} can intercept is during
breaks_pretty()
. I've tried passing different options topretty()
to preserve some formatting advantages: they don't work. I've settled on just returning the limit because it is not unreasonable to assume that if you want to label one and only one thing, the label should be at the thing you want rather than at some 'pretty' location you don't have data for.Reprex from issue:
Created on 2024-10-07 with reprex v2.1.1