fix: add knitr to website deps for use_article if not already in desc…

…ription
r-lib · Apr 13, 2024 · 73929f5 · 73929f5
1 parent 9e64daf
commit 73929f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/R/vignette.R b/R/vignette.R
@@ -42,6 +42,9 @@ use_article <- function(name, title = name) {
   check_is_package("use_article()")
 
   deps <- proj_deps()
+  if (!"knitr" %in% deps$package) {
+    proj_desc_field_update("Config/Needs/website", "knitr", append = TRUE)
+  }
   if (!"rmarkdown" %in% deps$package) {
     proj_desc_field_update("Config/Needs/website", "rmarkdown", append = TRUE)
   }

diff --git a/tests/testthat/test-vignette.R b/tests/testthat/test-vignette.R
@@ -50,7 +50,7 @@ test_that("use_article() adds rmarkdown to Config/Needs/website", {
 
   expect_setequal(
     proj_desc()$get_list("Config/Needs/website"),
-    c("rmarkdown", "somepackage")
+    c("knitr", "rmarkdown", "somepackage")
   )
 })