Polish upkeep bullets #1905
Merged
Polish upkeep bullets #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
approved these changes
Oct 30, 2023
Comment on lines
-147
to
+153
| todo(" | ||
| `usethis::use_package_doc()` | ||
| Consider letting usethis manage your `@importFrom` directives here. | ||
| `usethis::use_import_from()` is handy for this."), | ||
| todo(" | ||
| `usethis::use_testthat(3)` and upgrade to 3e, \\ | ||
| [testthat 3e vignette](https://testthat.r-lib.org/articles/third-edition.html)"), | ||
| todo(" | ||
| Align the names of `R/` files and `test/` files for workflow happiness. | ||
| The docs for `usethis::use_r()` include a helpful script. | ||
| `usethis::rename_files()` may be be useful."), | ||
| todo("`usethis::use_package_doc()`"), | ||
| todo("`usethis::use_testthat(3)`"), | ||
| todo("Align the names of `R/` files and `test/` files"), |
There was a problem hiding this comment.
In general, I like having detail, links, etc. But I can also imagine this is about making the items for the distant past more lean, yeah? And saving detail for the items we are more likely to be engaging with in the year of our lord 2023?
| * [ ] Add alt-text to pictures, plots, etc; see https://posit.co/blog/knitr-fig-alt/ for examples | ||
|
|
||
| ### Eternal |
jennybc
approved these changes
Oct 30, 2023
tests/testthat/_snaps/upkeep.md
Outdated
| @@ -36,7 +36,7 @@ | |||
| * [ ] Update email addresses *@rstudio.com -> *@posit.co | |||
| * [ ] Update copyright holder in DESCRIPTION: `person("Posit Software, PBC", role = c("cph", "fnd"))` | |||
| * [ ] `Run devtools::document()` to re-generate package-level help topic with DESCRIPTION changes | |||
There was a problem hiding this comment.
Suggested change
| * [ ] `Run devtools::document()` to re-generate package-level help topic with DESCRIPTION changes | |
| * [ ] Run `devtools::document()` to re-generate package-level help topic with DESCRIPTION changes |
Not in the diff but something I just noticed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.