Cli tweaks #1959
Cli tweaks #1959
Conversation
…be done later (when the work is done)
There was a problem hiding this comment.
Thanks for (most of) this 😅
It would make things easier for me to review and merge if the PR was less of a grab bag. Because some of it's no-brainer stuff I'm definitely looking for. But other changes are more opinions and seem to be where we have different opinions.
R/pr.R
Outdated
| code <- glue('pr_init("{branch}")') | ||
| ui_abort(c( | ||
| "x" = "No branch named {.val {branch}} exists.", | ||
| "_" = "Call {.code {code}} to create a new PR branch." | ||
| "_" = "Call {.run usethis::pr_init('{branch}')} to create a new PR branch." |
There was a problem hiding this comment.
What's the reasoning for fiddling with this?
There was a problem hiding this comment.
To create a run link. I tweaked it slightly in 2a93251, which seems less invasive?
| use_readme_md() | ||
| img <- magick::image_write(magick::image_read("logo:"), "logo.png") | ||
| withr::local_options(usethis.quiet = FALSE) | ||
| expect_snapshot(use_logo("logo.png"), transform = scrub_testpkg) |
There was a problem hiding this comment.
Is there a way to actually test for "clickable path"? Because it doesn't feel perceivable from the current snapshot.
There was a problem hiding this comment.
Well the single quotes in the snapshot indicates that some markup was applied (and that it could actually find README.md) 'README.md'.
|
Thanks! |
Follow-up to #1956 with mostly minor tweaks, but 3 more notable changes
use_logo()now adds a link to README if it exists. a5ca3b8check_is_package()adds a link to help iswhos_askingis provided. 269d2a2