Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lots of deprecated functions, arguments, badges #2027

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Jul 25, 2024

I feel so much lighter!

@jennybc jennybc requested a review from hadley July 25, 2024 18:32
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦝 🗑️ 🥳

#'
#' @keywords internal
#' @export
use_tidy_labels <- function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO you could remove these since they're mostly tidyverse internal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had had the same thought. I'll go for it.

jennybc added 2 commits July 25, 2024 14:46
They were deprecated as of v2.1.0 as opposed to v2.0.0. But I feel OK about this because they are (1) only meant for tidyverse maintainers and (2) unlikely to be used programmatically anywhere.
@jennybc jennybc merged commit ef3d516 into main Jul 25, 2024
12 checks passed
@hadley hadley deleted the remove-more-deprecations branch July 25, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants