Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add withr wrappers for verbose envar. #71

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Add withr wrappers for verbose envar. #71

merged 2 commits into from
Dec 11, 2024

Conversation

maciekbanas
Copy link
Member

Closes #57

@maciekbanas maciekbanas requested a review from kalimu December 11, 2024 11:44
@maciekbanas maciekbanas linked an issue Dec 11, 2024 that may be closed by this pull request
Use withr local_envar for controlling verbose in tests #57
Closed
@maciekbanas maciekbanas self-assigned this Dec 11, 2024
kalimu
kalimu approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@kalimu kalimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works. And for the future you can use in this context local_envvar() at the beginning of the test and left the rest of the code. It will clean up after itself automatically.
And no need for those additional ({ }) this way.

@maciekbanas
Copy link
Member Author

@kalimu I will fix it as I need to fix also cmd-checks

@maciekbanas maciekbanas merged commit fe00850 into main Dec 11, 2024
5 checks passed
@maciekbanas maciekbanas deleted the maciekbanas/57/use-withr-local_envar-for-controlling-verbose-in-tests branch December 11, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalimu kalimu kalimu approved these changes

Assignees

@maciekbanas maciekbanas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use withr local_envar for controlling verbose in tests
2 participants
@maciekbanas @kalimu