Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update polkadot to v1.13.0 #35

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Jul 25, 2024

Link to issue: #34

  • Node
  • Runtime

Compilation Outcome

  • ✅ rustc 1.77.2 (25ef9e3d8 2024-04-09)

CHANGELOG

  • WASM builder with metadata hash
  • Update crates to polkadot 1.13.0 with psvm -v 1.13.0
  • Remove parameterized-consensus-hook feature flag. Mentioned here
- cumulus-pallet-parachain-system = { version = "0.12.0", default-features = false, features = ["parameterized-consensus-hook"] }
+ cumulus-pallet-parachain-system = { version = "0.13.0", default-features = false }
  • The RuntimeGenesisConfig generic type parameter was removed from GenericChainSpec struct. Mentioned here
- pub type GenericChainSpec = sc_service::GenericChainSpec<(), Extensions>;
+ pub type GenericChainSpec = sc_service::GenericChainSpec<Extensions>;
  • Bound XCMP queue
  • Pin dependency version
mmr-rpc = "=35.0.0"
polkadot-node-core-pvf-common = "=14.0.0"
sc-network-types = "=0.12.0"
sp-runtime = { version = "=38.0.0", default-features = false }
sc-client-api = "=35.0.0"

node/src/service.rs Outdated Show resolved Hide resolved
@Daanvdplas Daanvdplas self-requested a review August 7, 2024 12:51
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the frame metadata signed extension (which also needs this, besides importing the dependency).

@AlexD10S AlexD10S self-requested a review August 7, 2024 14:38
@AlexD10S
Copy link
Collaborator

AlexD10S commented Aug 7, 2024

I am getting an error:

use of undeclared crate or module `frame_metadata_hash_extension`

I think it only needs to import frame-metadata-hash-extension (https://github.com/r0gue-io/contracts-parachain/blob/main/Cargo.toml#L43).

Before merging this PR, I would like to merge these two PRs first so that we can have everything in v1.12 before moving base-parachain to v1.13.

@chungquantin chungquantin requested a review from Daanvdplas August 8, 2024 04:59
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants