Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump zombienet version to v0.2.18 #352

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

pepoviola
Copy link
Contributor

Fix fn nodes() visibility.

Thanks!

@Daanvdplas
Copy link
Collaborator

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.64%. Comparing base (e99f719) to head (53557b4).
Report is 212 commits behind head on main.

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   75.62%   75.64%   +0.01%     
==========================================
  Files          62       59       -3     
  Lines       12720    12711       -9     
  Branches    12720    12711       -9     
==========================================
- Hits         9620     9615       -5     
+ Misses       1806     1803       -3     
+ Partials     1294     1293       -1     

see 7 files with indirect coverage changes

@AlexD10S
Copy link
Collaborator

AlexD10S commented Nov 28, 2024

Thanks for that @pepoviola
We use cargo-deny https://embarkstudios.github.io/cargo-deny/cli/check.html to ensure that the dependencies we add are free of vulnerabilities. However, it seems that the check is currently failing in the CI pipeline: https://github.com/r0gue-io/pop-cli/actions/runs/12030329241/job/33588146318?pr=352

You can run it locally with cargo-deny check.

If the issue cannot be resolved within the library, you can address it by adding the following line to the deny.toml:
https://github.com/r0gue-io/pop-cli/blob/main/deny.toml#L8 with the ID is failing, in this case RUSTSEC-2024-0399

@AlexD10S AlexD10S self-requested a review December 11, 2024 11:30
@AlexD10S
Copy link
Collaborator

There seems to be a version mismatch with subxt. We’ll need to update the versions in some dependencies of pop-cli before we can use the latest version of zombienet.

subxt-signer = { version = "0.38.0", features = ["subxt", "sr25519"] }
subxt = "0.38.0"
sp-core = "32.0.0"
sp-weights = "31.0.0"
contract-build = "5.0.0"
contract-extrinsics = "5.0.0"
contract-transcode = "5.0.0"
scale-info = { version = "2.11.4", default-features = false, features = ["derive"] }
scale-value = { version = "0.17.0", default-features = false, features = ["from-string", "parser-ss58"] }

@AlexD10S AlexD10S changed the title bump zombienet version to v0.2.17 bump zombienet version to v0.2.18 Dec 13, 2024
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience in fixing everything and for the amazing Zombienet-SDK.

@AlexD10S AlexD10S merged commit 110b9bf into r0gue-io:main Dec 13, 2024
19 checks passed
Daanvdplas pushed a commit that referenced this pull request Dec 17, 2024
* bump zombienet version

* bump zombienet version

* update lock

* update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants