Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for pop build parachain #81

Merged
merged 13 commits into from
Mar 25, 2024

Conversation

brunopgalvao
Copy link
Contributor

Unit test for pop build parachain

@brunopgalvao brunopgalvao changed the title test: add unit test for pop build parachain test: add unit test for pop build parachain Mar 21, 2024
@brunopgalvao brunopgalvao requested a review from weezy20 March 21, 2024 12:41
@brunopgalvao
Copy link
Contributor Author

Not sure why the CI is failing. Works fine on my machine.

@weezy20
Copy link
Contributor

weezy20 commented Mar 21, 2024

@brunopgalvao setup protoc on the CI. Some dependency wants that.

@AlexD10S
Copy link
Collaborator

AlexD10S commented Mar 21, 2024

Build the parachain is very slow, and now running cargo test can take a while. I opened an Issue about that a while ago: #18

Any thoughts on how to improve this? Should we add a feature flag as suggested there?

src/engines/parachain_engine.rs Outdated Show resolved Hide resolved
src/engines/parachain_engine.rs Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@brunopgalvao brunopgalvao requested a review from weezy20 March 22, 2024 09:42
@brunopgalvao
Copy link
Contributor Author

brunopgalvao commented Mar 22, 2024

Looks like we do need the wasm32-unknown-unknown target:

   Compiling parachain-template-runtime v0.7.0 (/tmp/.tmp4LtFzj/runtime)
error: failed to run custom build command for `parachain-template-runtime v0.7.0 (/tmp/.tmp4LtFzj/runtime)`

Caused by:
  process didn't exit successfully: `/tmp/.tmp4LtFzj/target/release/build/parachain-template-runtime-bdf6ae77f659e646/build-script-build` (exit status: 1)
  --- stderr
  Cannot compile the WASM runtime: the `wasm32-unknown-unknown` target is not installed!
  You can install it with `rustup target add wasm32-unknown-unknown` if you're using `rustup`.
warning: build failed, waiting for other jobs to finish...
test engines::parachain_engine::tests::test_parachain_build_after_instantiating_template ... FAILED

failures:

---- engines::parachain_engine::tests::test_parachain_build_after_instantiating_template stdout ----
thread 'engines::parachain_engine::tests::test_parachain_build_after_instantiating_template' panicked at src/engines/parachain_engine.rs:129:9:
Result should be Ok
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    engines::parachain_engine::tests::test_parachain_build_after_instantiating_template

test result: FAILED. 5 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1358.77s

error: test failed, to rerun pass `--bin pop`
Error: Process completed with exit code 101.

I have added it back in.

@brunopgalvao brunopgalvao dismissed weezy20’s stale review March 25, 2024 04:02

I have updated the PR according to your feedback.

@brunopgalvao brunopgalvao requested a review from AlexD10S March 25, 2024 04:03
@brunopgalvao brunopgalvao merged commit 33cbed0 into main Mar 25, 2024
1 check passed
@brunopgalvao brunopgalvao deleted the bruno/test-build-parachain branch March 25, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants