Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: feedback #18

Merged
merged 2 commits into from
Dec 18, 2024
Merged

docs: feedback #18

merged 2 commits into from
Dec 18, 2024

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S changed the base branch from main to peter/docs-use-wallet December 18, 2024 13:40
@AlexD10S AlexD10S requested review from al3mart and peterwht December 18, 2024 13:43
al3mart
al3mart approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving an approval an means to unlock if this is wanted :)

The main point for me would be whether the lack of icons for certain wallets is good or not.
I'd argue that showing the broad support is very very good.

@peterwht peterwht merged commit bc8bb98 into peter/docs-use-wallet Dec 18, 2024
1 check passed
@peterwht peterwht deleted the alex/docs-feedback branch December 18, 2024 19:01
AlexD10S added a commit that referenced this pull request Dec 19, 2024
@peterwht @al3mart
@AlexD10S @evilrobot-01
docs: docs and guides for --use-wallet (#16)
bb289ce 
* docs(wallet): add --use-wallet to command pages

* docs(wallet): two guides for secure signing

* docs(wallet): images with warning

* doc: explicitly mention insecure handling of secrets (#17)

* docs: feedback (#18)

* docs: include use-wallet info in the parachain onboarding docs

* style: update connect-wallet.png to show all wallets

* chore: update pictures to latest frontend

* docs: update `Sign` -> `Submit`, minor word adjustment

Co-authored-by: Frank Bell <[email protected]>

---------

Co-authored-by: Alejandro Martinez <[email protected]>
Co-authored-by: Alex Bean <[email protected]>
Co-authored-by: Frank Bell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al3mart al3mart al3mart approved these changes

@peterwht peterwht Awaiting requested review from peterwht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexD10S @al3mart @peterwht