feat: add native token support for fungibles api #309
Triggered via pull request
July 30, 2024 10:00
chungquantin
chungquantin
synchronize
#147
Status
Success
Total duration
12s
Artifacts
–
lint-pr.yml
on: pull_request_target
Validate PR title for conventional commit compliance
2s
Annotations
1 error and 3 warnings
|
mismatched types:
pallets/api/src/fungibles/benchmarking.rs#L71
error[E0308]: mismatched types
--> pallets/api/src/fungibles/benchmarking.rs:71:39
|
27 | / #[benchmarks(
28 | | where
29 | | <pallet_assets::Pallet<T, AssetsInstanceOf<T>> as Inspect<<T as frame_system::Config>::AccountId>>::AssetId: Zero,
30 | | )]
| |__- arguments to this function are incorrect
...
71 | _(RawOrigin::Signed(owner.clone()), asset_id.clone(), spender.clone(), approval_value);
| ^^^^^^^^^^^^^^^^ expected `fungibles::pallet::Config::AssetKind`, found `pallet_assets::Config::AssetId`
|
= note: expected associated type `<T as fungibles::pallet::Config>::AssetKind`
found associated type `<T as pallet_assets::Config<<T as fungibles::pallet::Config>::AssetsInstance>>::AssetId`
= note: an associated type was expected, but a different one was found
note: associated function defined here
--> pallets/api/src/fungibles/mod.rs:144:10
|
144 | pub fn approve(
| ^^^^^^^
145 | origin: OriginFor<T>,
146 | asset: T::AssetKind,
| -------------------
|
|
the borrowed expression implements the required traits:
scripts/fund-dev-accounts/./main.rs#L177
warning: the borrowed expression implements the required traits
--> scripts/fund-dev-accounts/./main.rs:177:47
|
177 | let query = pop::storage().system().account(&account.public_key().0.into());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `account.public_key().0.into()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
used a field initializer for a tuple struct:
scripts/fund-dev-accounts/./main.rs#L54
warning: used a field initializer for a tuple struct
--> scripts/fund-dev-accounts/./main.rs:54:9
|
54 | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `AssetId(Location { parents: 0, interior: Junctions::Here })`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
|
|
used a field initializer for a tuple struct:
scripts/fund-dev-accounts/./main.rs#L52
warning: used a field initializer for a tuple struct
--> scripts/fund-dev-accounts/./main.rs:52:36
|
52 | let assets = VersionedAssets::V4(Assets {
| __________________________________________^
53 | | 0: vec![Asset {
54 | | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
55 | | fun: amount,
56 | | }],
57 | | });
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
= note: `#[warn(clippy::init_numbered_fields)]` on by default
help: try
|
52 ~ let assets = VersionedAssets::V4(Assets(vec![Asset {
53 ~ id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
54 ~ fun: amount,
55 ~ }]));
|
|