-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove read state encoding #122
refactor: remove read state encoding #122
Conversation
9d2276c
to
a8c4bb5
Compare
0abd499
to
77c37f5
Compare
5c9e90f
to
b50830c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments which need addressing.
If it will always be one or more reads, we could attach an attribute to the read enum variants which defines the number of reads. That way the extension can just use that static number to precharge the relevant weight, but more importantly it is defined in the pallet. Alternatively it could be an actual weight value, but that might be something for the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, has merge conflicts tho.
Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Frank Bell <[email protected]>
Closes #101
Contract size from 7.4K to 7.1K
Created an issue to look into state query error handling #123