Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: uplift to polkadot 2412 #425

Draft
wants to merge 14 commits into
base: chore-upgrade-pop-net-to-stable2412/sc-1940
Choose a base branch
from

Conversation

peterwht
Copy link
Collaborator

@peterwht peterwht commented Jan 9, 2025

Uplifts to Stable 2412.

Due to dependency issues with asset-hub-westend-runtime with the 2412 release, integration-tests have been included from the workspace. The integration tests have been updated and confirmed to pass.

Relevant PRs causing node changes

Relevant PRs causing runtime changes

TODOs (in follow up PRs)

@peterwht peterwht changed the base branch from main to chore-upgrade-pop-net-to-stable2412/sc-1940 January 9, 2025 22:07
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 13.72549% with 44 lines in your changes missing coverage. Please review.

Please upload report for BASE (chore-upgrade-pop-net-to-stable2412/sc-1940@545a095). Learn more about missing BASE report.

Files with missing lines Patch % Lines
node/src/command.rs 0.00% 13 Missing ⚠️
node/src/service.rs 0.00% 13 Missing ⚠️
node/src/chain_spec.rs 0.00% 6 Missing ⚠️
pallets/nfts/src/features/transfer.rs 0.00% 2 Missing ⚠️
pallets/nfts/src/impl_nonfungibles.rs 0.00% 2 Missing ⚠️
extension/src/functions.rs 80.00% 0 Missing and 1 partial ⚠️
pallets/nfts/src/benchmarking.rs 0.00% 1 Missing ⚠️
pallets/nfts/src/lib.rs 0.00% 1 Missing ⚠️
runtime/devnet/src/config/api/versioning.rs 0.00% 1 Missing ⚠️
runtime/devnet/src/lib.rs 0.00% 1 Missing ⚠️
... and 3 more
@@                              Coverage Diff                               @@
##             chore-upgrade-pop-net-to-stable2412/sc-1940     #425   +/-   ##
==============================================================================
  Coverage                                               ?   68.31%           
==============================================================================
  Files                                                  ?       70           
  Lines                                                  ?    11777           
  Branches                                               ?    11777           
==============================================================================
  Hits                                                   ?     8045           
  Misses                                                 ?     3480           
  Partials                                               ?      252           
Files with missing lines Coverage Δ
extension/src/lib.rs 94.23% <100.00%> (ø)
pallets/api/src/mock.rs 100.00% <ø> (ø)
pallets/nfts/src/common_functions.rs 80.00% <100.00%> (ø)
primitives/src/lib.rs 90.78% <100.00%> (ø)
extension/src/functions.rs 92.41% <80.00%> (ø)
pallets/nfts/src/benchmarking.rs 85.79% <0.00%> (ø)
pallets/nfts/src/lib.rs 69.85% <0.00%> (ø)
runtime/devnet/src/config/api/versioning.rs 91.11% <0.00%> (ø)
runtime/devnet/src/lib.rs 5.44% <0.00%> (ø)
runtime/mainnet/src/lib.rs 21.44% <0.00%> (ø)
... and 7 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants