refactor: remove destroy witness

[chungquantin]

Remove the witness data required as parameter from destroy() dispatchable function of nonfungibles pallet.

• Pros: Improve developer experience.
• Cons: Pre-dispatch weight charged up to u32::MAX.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.90%. Comparing base (5316da1) to head (76acc65).

@@                              Coverage Diff                               @@
##           chungquantin/feat-main_pallet_nonfungibles     #445      +/-   ##
==============================================================================
- Coverage                                       73.93%   73.90%   -0.03%     
==============================================================================
  Files                                              76       76              
  Lines                                           15237    15227      -10     
  Branches                                        15237    15227      -10     
==============================================================================
- Hits                                            11265    11254      -11     
  Misses                                           3711     3711              
- Partials                                          261      262       +1     

Files with missing lines	Coverage Δ
pallets/api/src/nonfungibles/mod.rs	97.10% <100.00%> (+0.05%)	⬆️
pallets/api/src/nonfungibles/tests.rs	99.82% <100.00%> (-0.01%)	⬇️
runtime/devnet/src/config/api/mod.rs	90.97% <100.00%> (-0.20%)	⬇️

... and 1 file with indirect coverage changes

[peterwht]

Unfortunately, I think the devex of removing the witness (forcing high fees) does not outweigh the benefits of not requiring the witness.

A few things, destroy is likely something that is infrequently called. Additionally, I feel a better solution will be here: #432 (comment). However, to take that idea further, we can allow the smart contract to provide an optional maybe_witness. That way the choice is up to the SC developer.