Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove distutil from setup.py
Remove
distutils.version.LooseVersion
.Cython version checking is done in
pyproject.toml
so there is no need to check it.The ability to build if you have a
.cpp
files even if Cython is not installed will continue to be supported.ref: https://setuptools.pypa.io/en/latest/userguide/ext_modules.html#distributing-extensions-compiled-with-cython
Remove
distutils.spawn.spawn
anddistutils.errors.DistutilsExecError
.pyopenjtalk/setup.py
Lines 111 to 172 in 48dd78c
This bug seems to have been patched by
setuptools>=60.0.0
.Therefore, this code can be made unnecessary by changing the version of setuptools only on Windows.
It may be better to upgrade the version of setuptools on other OS as well.
However, since I can't reproduce pyopenjtalk cannot be installed in google colab #27 , So I leave it as is.