Feat(optimism): Optimism bridge #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b5fb22a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…stdk-plugins into optimism_bridge
…stdk-plugins into optimism_bridge
…stdk-plugins into optimism_bridge
jimobrien
reviewed
Sep 12, 2023
packages/optimism/src/Optimism.ts
Outdated
| } from '@eth-optimism/contracts-ts' | ||
| import { ETH_CHAIN_ID, CHAIN_ID_ARRAY } from './chain-ids.js' | ||
| import { ETH_TOKEN_ADDRESS } from './token-addresses.js' | ||
| // If you're implementing swap or mint, simply duplicate this function and change the name |
There was a problem hiding this comment.
can remove the template comments
There was a problem hiding this comment.
Good catch thanks, I'll keep an eye out for loose comments in the other branches too.
jimobrien
reviewed
Sep 12, 2023
packages/optimism/src/Optimism.ts
Outdated
|
|
||
| export const getSupportedTokenAddresses = async (_chainId: number) => { | ||
| // Given a specific chain we would expect this function to return a list of supported token addresses | ||
| return [] |
There was a problem hiding this comment.
this should return the tokens listed in packages/optimism/src/token-addresses.ts
…into optimism_bridge
Addresses PR review comments
…stdk-plugins into optimism_bridge
…into optimism_bridge
…stdk-plugins into optimism_bridge
…into optimism_bridge
jimobrien
approved these changes
Sep 15, 2023
…into optimism_bridge
Merged
Quazia
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mmackz
added a commit
that referenced
this pull request
Mar 2, 2024
* delete test * feat: add jojo stake plugin * Chore: bump pnpm 8.15.3 * test * Feat(zora): add simulateMint * Feat(mirror): add simulateMint * Feat(sound): add mintSimulate * chore: format * Chore: changeset * Version Packages (alpha) * add zod as a dev dependency * add script * add js-yaml * update * test * commonjs * things * install types * why not * change * logs * drop catch * set path * add url to schema * add test plugin * chore: format * update config * add comment * exit on error * fill in details * add check for new packages * remove config * add type notations * branches * target fork * :( * 1 * Feat(registry): add getTxSimulation to registry * 2 * Chore: delete questk pnpm-workspace.yaml * lfg * types * add details * update message * Fix: root tsconfig * Fix: tweak root tsconfig * chore: format * Chore: changeset * Chore: fully remove tsconfig from root * update script * Chore: remove per-app pnpm enforcement * remove icon * chore: version package (alpha) * update * update * add details * remove logs * pass tests * add branch * test merge * fix: delete TOKEN_JUSD * Chore(utils): add sepolia to chain-ids * Chore(types): make tokenId option for mint intent * Fix(zora): update ABI, Save legacy mint in seperate ABI * Feat(zora): add mint cop addresses * Feat(utils): ADD TREASURY CONST * Feat(zora): update intent/simulation with new contract * Test(zora): simulation * chore: format * Chore: cleanup * chore: format * Fix: update simulation return types * added export for tokens directory * chore: format * chore: format * added changeset * Test(zora): remove only * Test(zora): update test data * Chore(deps): bump codecov/codecov-action from 4.0.1 to 4.1.0 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.0.1...v4.1.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Refactor(zora): use viem pad over helper Thanks for the tip @jonathandiep * Chore(zora): remove stray log * Chore: changeset * refactor(jojo): remove template comments * refactor(jojo): convert bigint to string value * chore: version package (alpha) * Fix(zora): remove extra msgArgs * chore: version package (alpha) * validateicon * update action * use ngrok for testing * Fix config file format verification script * update iconoption * change ngrok url * fix logo url * fix logo url * verify unique urls * add env override * add script to register plugin details * change install node step * fix namespace issue * updatefail logic * fix --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: almo <[email protected]> Co-authored-by: Quazia <[email protected]> Co-authored-by: Quazia <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: mmackz <[email protected]> Co-authored-by: veganbeef <[email protected]> Co-authored-by: veganbeef <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add more tests. There was a lot more assistance from published Optimism repos for this one, and even fewer networks to deal with. One complexity - they use slightly different functions if there's a recipient. Not quite sure how to handle that yet I'm going to have to figure it out in the testing but something to watch for.