Feat(polygon): Polygon bridge #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63285d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/polygon/package.json
Outdated
Comment on lines
37
to
51
| "devDependencies": { | ||
| "@types/node": "^20.4.5", | ||
| "@vitest/coverage-v8": "^0.33.0", | ||
| "rimraf": "^5.0.1", | ||
| "rome": "^12.1.3", | ||
| "ts-node": "^10.9.1", | ||
| "tsconfig": "workspace:*", | ||
| "typescript": "^5.1.6", | ||
| "vitest": "^0.33.0" | ||
| }, | ||
| "dependencies": { | ||
| "@maticnetwork/pos-portal": "^1.5.2", | ||
| "@rabbitholegg/questdk": "1.0.1-alpha.8", | ||
| "viem": "^1.2.15" | ||
| } |
There was a problem hiding this comment.
We should probably keep dependencies pinned for any plugins / sdks that other users will consume
There was a problem hiding this comment.
Agreed - I'll capture this as an issue
…tdk-plugins into polygon_bridge
…into polygon_bridge
…into polygon_bridge
…tdk-plugins into polygon_bridge
jimobrien
approved these changes
Sep 15, 2023
…into polygon_bridge
Merged
Quazia
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest issue here is that the L1 ERC20 function signature doesn't have an amount. Polygon in general handles stuff super weird and I'm not very happy with this integration. They also have this concept around token predicates that is basically an alternative bridging flow but it's not supported through the UI.
Edit: Got the amount issue resolved on L1 ERC20. Not going to bother with the predicates right now as best I can tell they arn't used through the front-end anyhow.