feat(pods): use referral in mint validation #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c52d23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…date-pods-to-use-referral-param
mmackz
commented
Jul 16, 2024
packages/pods/src/Pods.ts
Outdated
| { mintReferral: checksumAddress }, | ||
| { | ||
| rewardsRecipients: { | ||
| $and: [{ $first: checksumAddress }, { $last: checksumAddress }], |
There was a problem hiding this comment.
@Quazia We want to make sure that the referral is the only item in the array. Would using an array literal work better here? ie: rewardsRecipients: [checksumAddress]
There was a problem hiding this comment.
Used the array literal instead of $and.
jonathandiep
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses
referralparam in mint validationuses
referralfrom action params in simulate int and mint intents functionsadd tests to verify referral validation is working correctly
feat(utils): add referral property to MintActionParams #475
Fixes BOOST-4258
https://linear.app/rh-app/issue/BOOST-4258/update-pods-to-use-referral-param-in-mint-validation-function