-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zora): use referral
param in validation and simulations
#481
feat(zora): use referral
param in validation and simulations
#481
Conversation
🦋 Changeset detectedLatest commit: bee49cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…date-zora-to-use-referral-param
…date-zora-to-use-referral-param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but same question around wondering if we use define default referral address in utils. Also might be worthwhile to just alias the deployed address so they aren't bound to the same variable but that may be an unnecessary optimization.
packages/zora/src/Zora.ts
Outdated
@@ -126,6 +127,17 @@ export const mint = async ( | |||
tokenId, | |||
}) | |||
} | |||
if (referral) { | |||
const referralAddress = getAddress(referral) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always return check summed - I'd add a callout since elsewhere we consistently use lower case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this line since using a checksummed address is not required anymore.
I was using an array operator previously for the rewardsRecipients
, which required a checksummed address.
I have a ZORA_DEPLOYER_ADDRESS used in several plugins now, so it would make sense to save it as |
use referral param for simulations and validation
add additional tests
feat(utils): add referral property to MintActionParams #475
Fixes BOOST-4257
https://linear.app/rh-app/issue/BOOST-4257/update-zora-to-use-referral-param-in-mint-validation-function