Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zora): use referral param in validation and simulations #481

Merged
merged 18 commits into from
Jul 16, 2024

Conversation

mmackz
Copy link
Collaborator

@mmackz mmackz commented Jul 15, 2024

@mmackz mmackz requested a review from a team as a code owner July 15, 2024 20:25
Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: bee49cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@rabbitholegg/questdk-plugin-zora Minor
@rabbitholegg/questdk-plugin-registry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Quazia Quazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but same question around wondering if we use define default referral address in utils. Also might be worthwhile to just alias the deployed address so they aren't bound to the same variable but that may be an unnecessary optimization.

@@ -126,6 +127,17 @@ export const mint = async (
tokenId,
})
}
if (referral) {
const referralAddress = getAddress(referral)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always return check summed - I'd add a callout since elsewhere we consistently use lower case

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this line since using a checksummed address is not required anymore.

I was using an array operator previously for the rewardsRecipients, which required a checksummed address.

@mmackz
Copy link
Collaborator Author

mmackz commented Jul 16, 2024

LGTM but same question around wondering if we use define default referral address in utils. Also might be worthwhile to just alias the deployed address so they aren't bound to the same variable but that may be an unnecessary optimization.

I have a ZORA_DEPLOYER_ADDRESS used in several plugins now, so it would make sense to save it as REFERRAL_ADDRESS and export it from utils. Ill submit a ticket and make the changes at a later date.

@mmackz mmackz merged commit 34b465e into main Jul 16, 2024
9 checks passed
@mmackz mmackz deleted the matthew/boost-4257-update-zora-to-use-referral-param branch July 16, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants