-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate amqp library #194
Merged
Merged
Migrate amqp library #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
force-pushed
the
migrate_amqp_library
branch
7 times, most recently
from
May 22, 2024 09:01
e70d0b9
to
93b73c2
Compare
DanielePalaia
force-pushed
the
migrate_amqp_library
branch
from
May 22, 2024 09:05
93b73c2
to
241a4b3
Compare
DanielePalaia
force-pushed
the
migrate_amqp_library
branch
2 times, most recently
from
May 28, 2024 08:07
c51ffdc
to
0490a38
Compare
DanielePalaia
force-pushed
the
migrate_amqp_library
branch
from
May 28, 2024 08:33
0490a38
to
efa7b49
Compare
Gsantomaggio
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved per pairing with @DanielePalaia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #183
The uamqp library has been replaced with the code used here:
https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp
to allow support for ARM architecture and because the uamqp library wouldn't be supported after 2025 anyway.
It seems like this library is also 15/20% faster than the original one.
In this library we are missing the body type which is automatically able to detect the type passed and to the conversion so we need to pass a binary like:
Also if you were previously using amqp fields like Properties this are now imported from rstream directly:
Before
Now:
This library is also using typing_extensions as dependency which needs to be included in your application (uamqp is not used anymore and can be removed).