Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving producers/consumers client connection creation to Environment #259

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

DanielePalaia
Copy link
Contributor

Moving client connection creation from Producers/Consumers to Environment could help a better management of the disconnection in the future as this methods need to be called eventually to reconnect

@DanielePalaia DanielePalaia marked this pull request as draft November 22, 2024 15:19
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 59.52381% with 34 lines in your changes missing coverage. Please review.

Project coverage is 89.50%. Comparing base (6e46906) to head (897e9be).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/environment.rs 56.41% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   89.23%   89.50%   +0.26%     
==========================================
  Files          80       80              
  Lines        7003     7021      +18     
==========================================
+ Hits         6249     6284      +35     
+ Misses        754      737      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DanielePalaia
Copy link
Contributor Author

@wolf4ood what do you think?

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple of nits

src/consumer.rs Outdated Show resolved Hide resolved
src/producer.rs Outdated Show resolved Hide resolved
@DanielePalaia
Copy link
Contributor Author

I think we can merge this one. The codecov is complaining because the LoadBalancer mode seems missing tests but it was like that even before

@DanielePalaia DanielePalaia marked this pull request as ready for review November 25, 2024 08:30
@DanielePalaia DanielePalaia merged commit 1de1526 into main Nov 25, 2024
3 of 4 checks passed
@DanielePalaia DanielePalaia deleted the improve_disconnection_management branch November 25, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants