Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): Add CompatTelRunner.exe as an exclusion in Unusual process modified registry run key rule #449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

N0vaSky
Copy link
Contributor

@N0vaSky N0vaSky commented Feb 24, 2025

What is the purpose of this PR / why it is needed?

Added CompatTelRunner.exe as an exclusion to reduce false positives on this rule.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


Copy link
Owner

@rabbitstack rabbitstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rabbitstack rabbitstack changed the title Added CompatTelRunner.exe as an exclusion to persistence_unusual_process_modified_registry_run_key.yml fix(rules): Add CompatTelRunner.exe as an exclusion in Unusual process modified registry run key rule Mar 8, 2025
@rabbitstack
Copy link
Owner

@DiagnosticNinja you'll have to bump the rule version to make the CI check happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants