test: correct logic in unit test

raccoongang · Feb 21, 2024 · 043f344 · 043f344
1 parent 04cba7e
commit 043f344
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lms/djangoapps/mobile_api/course_info/test_views.py b/lms/djangoapps/mobile_api/course_info/test_views.py
@@ -291,18 +291,18 @@ def test_get_requested_user(self, user_role, username, expected_username, mock_g
         elif user_role == "staff":
             request_user = self.admin_user
         elif user_role == "student":
-            request_user = self.user
+            request_user = self.student_user
 
         self.request.user = request_user
 
         if expected_username:
-            expected_user = User.objects.get(username=expected_username)
-            mock_get.return_value = expected_user
+            mock_user = UserFactory(username=expected_username)
+            mock_get.return_value = mock_user
         else:
-            expected_user = None
+            mock_get.side_effect = User.DoesNotExist()
 
         result_user = BlocksInfoInCourseView().get_requested_user(self.request.user, username)
-        if expected_user:
+        if expected_username:
             self.assertEqual(result_user.username, expected_username)
             mock_get.assert_called_with(username=username)
         else: